Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

135 add function to insert md links #136

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maw
Copy link
Contributor

@maw maw commented Jul 24, 2022

This is for #135, should be mostly self-explanatory.

I didn't include a rebuilt zetteldeft.el here. I can add it if you want it though.

@EFLS
Copy link
Owner

EFLS commented Aug 5, 2022

Looks relevant. As I don't use Zetteldeft with Markdown notes myself, what is exactly the benefit of formatting this as a Markdown link? I'm just wondering whether this leaves enough flexibility for users with Markdown notes. I feel hesitant to steer those users in a specific direction.

Here in the zd-tutorial (https://github.com/EFLS/zd-tutorial/blob/master/2020-04-17-1532%20Zetteldeft%20and%20Markdown.org), for example, I suggest a way to use Zetteldeft on The Archive style notes, which look like [[2022-08-05-1212 This]] (i.e., w. a link suffix). Not sure whether this PR would make things a bit more complicated.

Perhaps I can include your suggested code in the zd-tutorial?

@EFLS
Copy link
Owner

EFLS commented Aug 5, 2022

Or maybe we include this, but an 'The Archive' style as well...

@maw
Copy link
Contributor Author

maw commented Aug 17, 2022

@EFLS to me, it just feels more "markdowney". Other people might disagree.

During the past year and a half (!) that I've been using zetteldeft I tried out various ways to include or display links and this is what I settled on. (The downside: I occasionally click on these links by mistake.)

I think including it and also adding a 'The Archive' style function as well would be good.

In theory, long term, I'd worry about the list of options for zetteldeft-insert-link-function getting unwieldy -- although it also seems like it'd be a good problem to have: lots of contributions, diverse uses and users, etc. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants